Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projen): change mergify configuration property #6

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

antonio-marquez-perez
Copy link
Member

@antonio-marquez-perez antonio-marquez-perez commented Nov 16, 2023

Describe your changes

We create a mergify configuration throuhg projen file, but one of the properties was declared wrong.

Checklist for the author of the Pull-Request

  • My code follows the style guideline
  • The commit message follows our guideline: (TODO: Add a link to the article)
  • I have performed a self-review of my own code
  • I added a unit and feature or request test for the new functionality
  • Tested the changes in this pull-request myself
  • I have made corresponding changes to the documentation
  • I updated the README.md

Checklist for the reviewers

  • The code follows the style guidelines
  • All the linters are passed
  • All tests are passed
  • The implementation corresponds to the use case which described in the task
  • All the new features have documentation and an additional information for the README.md was provided
  • There is no redundant or commented code
  • The code is readable and understandable.

ISSUES CLOSED: 5

The configuration was incorreccly named and it caused errors when Mergify execute their jobs

ISSUES CLOSED: 5
@antonio-marquez-perez antonio-marquez-perez added the bug Something isn't working label Nov 16, 2023
@antonio-marquez-perez antonio-marquez-perez self-assigned this Nov 16, 2023
@antonio-marquez-perez antonio-marquez-perez linked an issue Nov 16, 2023 that may be closed by this pull request
we remoge delete branches property, it is shown an error in mergify

ISSUES CLOSED: 5
@antonio-marquez-perez antonio-marquez-perez added reviewed Code Reviewed and ready to be merged and removed bug Something isn't working labels Nov 16, 2023
@antonio-marquez-perez antonio-marquez-perez merged commit fe3ba3b into main Nov 16, 2023
10 of 11 checks passed
@antonio-marquez-perez antonio-marquez-perez deleted the fix/5-mergify-property-incorrect branch November 16, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Code Reviewed and ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mergify property incorrect
1 participant